FE: CG: Fix names display overflow issue #541
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapybro
bot
added
status/triage
Haarolean
reviewed
Sep 25, 2024
| color: ${table.td.color.normal}; | ||
| font-weight: 500; | ||
| max-width: 450px; | ||
| max-width: 150ch; |
Member
There was a problem hiding this comment.
as far as I can see we do not use ch anywhere yet and not sure how introducing these is legit. @Mgrdich ideas?
Contributor
There was a problem hiding this comment.
i am not sure about the ch
While the ch unit works as an exact measurement for monospaced / fixed width fonts like Courier, it can be unpredictable with proportional fonts like Arial
Haarolean
changed the title
Haarolean
added
scope/frontend
Haarolean
added
the
hacktoberfest-accepted
|
Further user feedback is requested. Please reply within 7 days or we might close the issue. |
|
No feedback received within 7 days. Auto closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make?
This pull request addresses a bug in Kafka UI where consumer group IDs sometimes appear truncated due to insufficient space for display. The issue affects the readability of consumer group names on the consumer groups page.
Changes Include:
Is there anything you'd like reviewers to focus on?
Please review the changes to confirm:
Fixes #528